Linux: Fixes #15030: Upgrade electron-builder#15043
Linux: Fixes #15030: Upgrade electron-builder#15043personalizedrefrigerator wants to merge 4 commits intolaurent22:devfrom
electron-builder#15043Conversation
See laurent22#15034 Co-authored-by: JGCarroll <JGCarroll@users.noreply.github.com>
|
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Joplin_install_and_update.sh`:
- Around line 182-197: The libfuse2 gating uses compareVersions with
RELEASE_VERSION which can contain prerelease suffixes (e.g., "3.6.9-pre1")
causing numeric compare failures; sanitize the version before the check by
stripping any prerelease suffix (remove everything after the first '-' from
RELEASE_VERSION) and use that sanitized value in the compareVersions call used
in the libfuse2 block (referencing compareVersions and RELEASE_VERSION), or
alternatively enhance compareVersions to ignore non-numeric patch suffixes;
ensure the sanitized variable is used in the existing libfuse2 check so
prereleases are treated by their core numeric version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f5a55608-1d2b-402b-a8b2-cbf0fcd22506
⛔ Files ignored due to path filters (3)
.yarn/patches/app-builder-lib-npm-24.13.3-86a66c0bf3.patchis excluded by!**/.yarn/**.yarn/patches/app-builder-lib-npm-26.8.1-e88d27929a.patchis excluded by!**/.yarn/**yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
Joplin_install_and_update.shpackage.jsonpackages/app-desktop/package.json
Note: This change addresses issues found by Claude Code during a review.
Created electron-userland/electron-builder-binaries#147 as this is a problem with the bundled Since Joplin releases are built in 22.04 runners, this isn't really a problem from a packaging POV as the AppImage would still be forwards compatible as it currently is. However it does potentially cause friction with contributions from users. This would mean the At this point I think it's worth verifying whether the stable 3.5 series AppImage does actually run in Fedora 44 - explicitly confirming Fedora has dropped If Fedora 44 has removed Edit: I have tested Fedora 44 Workstation in a VM, the urgency of this fix has gone down since installing |
electron-builderelectron-builder
|
https://github.com/electron-userland/electron-builder/releases/tag/electron-builder%4026.9.0 I'd tried build this branch, changing the Unfortunately, From the release notes for 26.9.0:
This looks relevant to our issue above (looking in the Electron-Builder commits, there were some changes to
This is worth investigating (does it mean we can drop the |
Problem
electron-buildercreates AppImages that depend on a deprecatedlibfuse2library. This makes the installation process more difficult (users need to installlibfuse2). According to #15030,libfuse2will no longer be included in the Fedora 44 package repository.Solution
Note
This pull request is a modified version of @JGCarroll's #15032.
Upgrade
electron-builderand instruct Electron Builder to use a modern AppImage runtime (see #15032).Resolves #15030.
Testing
MacOS 26.4 (x86_64)
yarn distcan build a.dmgand.pkgfile.gettextto build the.pkgfile..dmgfilesize hasn't significantly increased (current size: 168 MB)..dmgfile..dmgcan sync to Joplin Cloud.Linux: Fedora 43
.debandAppImagepackages build (yarn dist).AppImagesize hasn't significantly increased (current size: 204 MB).AppImagestarts.Ubuntu 26.04 beta
AppImage and deb
Build currently doesn't seem to work in Ubuntu 26.04 beta (error:
version `GLIBC_2.43' not found (required by basename)while runningyarn dist). However, the AppImage and.debfiles built on Fedora 43 seem to work:./Joplin-3.6.7.AppImage --no-sandbox.sudo dpkg -i ./Joplin-3.6.7.deb(andlibxss1viaapt), it's possible to open Joplin from the application menu.Install script
bash Joplin_install_and_update.shwithoutlibfuse2installed fails with "Error: Can't get libfuse2 on system, please install libfuse2".libfuse2)libfuse2t64, reverting the install script patch, and removing the previously-installed AppImage, it's possible to install Joplin 3.5.13. Joplin 3.5.13 can be launched from the application menu.Windows
app-builder-lib.